Code clean-up #168
Merged
Code clean-up #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
force-pushed
the
feature/code-cleanup
branch
3 times, most recently
from
a4dc89e to
43944cc
Compare
rimi-itk
force-pushed
the
feature/code-cleanup
branch
3 times, most recently
from
b849e83 to
efa9729
Compare
rimi-itk
force-pushed
the
feature/code-cleanup
branch
from
efa9729 to
a538d3d
Compare
rimi-itk
requested review from
jekuaitk and
stankut
and removed request for
stankut
jekuaitk
approved these changes
Apr 29, 2025
Co-authored-by: Jeppe Kuhlmann Andersen <[email protected]>
rimi-itk
force-pushed
the
feature/code-cleanup
branch
from
74bd5b0 to
2870526
Compare
rimi-itk
force-pushed
the
feature/code-cleanup
branch
from
2870526 to
c5d6763
Compare
jekuaitk
approved these changes
Apr 30, 2025
Comment on lines
+131
to
+138
| > [!TIP] | ||
| > If the `composer install` commands fails with | ||
| > | ||
| > > Unable to install module simplesamlphp/simplesamlphp-assets-base, package name must be on the form "VENDOR/simplesamlphp-module-MODULENAME". | ||
| > | ||
| > you can remove the `vendor` folder and rerun the `composer install` command (cf. | ||
| > <https://www.drupal.org/project/simplesamlphp_auth/issues/3350773>). | ||
Closed
Merged
stankut
approved these changes
May 28, 2025
|
@rimi-itk thanks for separate commits and a cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up code.