Skip to content

Conversation

@darrelmiller
Copy link
Member

No description provided.

@MikeRalphson
Copy link
Member

LGTM

Tests: 4 passing, 0 failing, 0 warnings

"links": [
{
"href": "http://127.0.0.1:8774/v2/",
"rel": "self"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fehguy
Copy link
Contributor

fehguy commented Mar 28, 2017

Please don't merge until we sort out the href purpose :D

@RobDolinMS RobDolinMS added this to the v3.0.0-rc1 milestone Apr 21, 2017
@RobDolinMS
Copy link
Contributor

@fehguy Do we still need to sort-out href purpose?

  • If yes, would you please link the Issue or PR?
  • If no, would you want to give this a LGTM?

@webron
Copy link
Member

webron commented Apr 28, 2017

examples need to be updated to the new construct.

@darrelmiller darrelmiller modified the milestones: v3.0.0-rc2, v3.0.0-rc1 Apr 28, 2017
@MikeRalphson
Copy link
Member

Responses Object keys must be quoted:

This field MUST be quoted for compatibility between JSON and YAML (i.e. "200")

@RobDolinMS
Copy link
Contributor

@darrelmiller Do you want to update the PR to address @webron's and @MikeRalphson's feedback, or would you like them to submit PRs?

@RobDolinMS
Copy link
Contributor

TDC: @darrelmiller has a few edits for this and will comment when ready.

@darrelmiller
Copy link
Member Author

Issues have been addressed. I'm going to be reckless and merge this without @OAI/tdc confirmation, because it doesn't affect the spec directly.

@darrelmiller darrelmiller merged commit b68f87a into OpenAPI.next May 18, 2017
@darrelmiller darrelmiller deleted the dm/examples branch May 18, 2017 14:33
@darrelmiller
Copy link
Member Author

And yet, I completely missed fixing the things I was supposed to be fixing. PSA: Don't merge PRs without at least two cups of coffee first.

@webron
Copy link
Member

webron commented May 18, 2017

Should this be reverted then?

@darrelmiller
Copy link
Member Author

@webron Nah. The changes are good, they are just not complete. I've almost finished doing the rest of the changes in a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants