-
Notifications
You must be signed in to change notification settings - Fork 9.2k
V3 Yaml Examples #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 Yaml Examples #985
Conversation
|
LGTM
|
| "links": [ | ||
| { | ||
| "href": "http://127.0.0.1:8774/v2/", | ||
| "rel": "self" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Please don't merge until we sort out the |
|
@fehguy Do we still need to sort-out
|
|
|
|
Responses Object keys must be quoted:
|
|
@darrelmiller Do you want to update the PR to address @webron's and @MikeRalphson's feedback, or would you like them to submit PRs? |
|
TDC: @darrelmiller has a few edits for this and will comment when ready. |
|
Issues have been addressed. I'm going to be reckless and merge this without @OAI/tdc confirmation, because it doesn't affect the spec directly. |
|
And yet, I completely missed fixing the things I was supposed to be fixing. PSA: Don't merge PRs without at least two cups of coffee first. |
|
Should this be reverted then? |
|
@webron Nah. The changes are good, they are just not complete. I've almost finished doing the rest of the changes in a new PR |
No description provided.