Issue #577: interface for paths #650
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ePaul
force-pushed
the
issue-577-interfaces
branch
from
b3d688c to
13fe6d9
Compare
Contributor
Author
|
After reading the comment by @webron in #536 about $ref in path items, I guess I should avoid doing the same here. Though #556 and #629 have some more discussion on that. |
This simply reuses the $ref property of a path item – not sure if that is the right thing to do, or if we should use an `interface` property instead.
…rom OAI#633. Also, rename it to "Interfaces Definitions Object".
ePaul
force-pushed
the
issue-577-interfaces
branch
from
13fe6d9 to
19f8cfd
Compare
Contributor
|
This is covered in another ticket and recommends invalid an invalid structure for JSON references. Closing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft implementation of #577 simply reuses the $ref property of a path item – not sure if that is the right thing to do, or if we should use a new
interfaceproperty instead (like for the schemas).This is also still missing the inclusion of the "interfaces" object in either the main object, or the schemas/definitions object (depending on #633).
I opened this pull request, so the discussion in #577 has something concrete to talk about.