Skip to content

Conversation

@ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Oct 19, 2025

Running on pull_request is sufficient, it will be triggered when pushing to the PR's head branch.

When running on pull requests, it only reports broken links in files changed by the PR. (Under the hood it still checks all files and then silently ignores broken links in files not changed by the PR 🤷🏻‍♂️)

When running on push, it reports broken links in all files, which is unfair to the PR author who didn't change the problematic file(s).


  • no schema changes are needed for this pull request

@ralfhandl ralfhandl force-pushed the main-adjust-linkspector-workflow branch from 27249c3 to fd8a112 Compare October 19, 2025 16:14
@ralfhandl ralfhandl marked this pull request as ready for review October 19, 2025 16:24
@ralfhandl ralfhandl requested review from a team as code owners October 19, 2025 16:24
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@ralfhandl ralfhandl merged commit 986bf13 into OAI:main Oct 19, 2025
2 checks passed
@ralfhandl ralfhandl deleted the main-adjust-linkspector-workflow branch October 19, 2025 17:10
@OAI OAI deleted a comment from moradalzabin306-hue Oct 20, 2025
@OAI OAI deleted a comment from moradalzabin306-hue Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants