-
Notifications
You must be signed in to change notification settings - Fork 9.2k
dev: build HTML from src/oas.md #4254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I tried this out and it works as advertised- thanks! One question: Could we put |
|
We can put |
|
We agreed to name the output directory |
scripts/md2html/build-src.sh
Outdated
| cd scripts/md2html | ||
|
|
||
| filename=src/oas.md | ||
| tempfile=../../deploy/oas/oas.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems odd to me that we're putting a tempfile under /deploy when our output is under /deploy-preview. Should we not have the tempfile there and named something obvious (eg. with tmp or temp in the name?) so that if something breaks the mess is left in the same place we were expecting output? And we can have an npm run clean-src that just deletes that directory so that it works whether the build was successful or not? (I don't care if you add clean-src in this PR or not, I'm just thinking it might be nice at some point).
npm run build-srcto build HTML from file filesrc/oas.mddeploy-preview/oas.htmldeploy-previewCONTRIBUTING.mdfrommain: dev: update from main #4271CONTRIBUTING.mdPart of