Skip to content

gh-pages: add Overlay #4144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

gh-pages: add Overlay #4144

merged 1 commit into from
Oct 22, 2024

Conversation

@ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Oct 18, 2024 •
edited
Loading

This PR adds the Overlay specification to the landing page of https://spec.openapis.org.

Note: merge only after the Overlay specification has been published!

Overlay publishing PR:

@ralfhandl ralfhandl added Housekeeping http Supporting HTTP features and interactions and removed http Supporting HTTP features and interactions labels Oct 18, 2024
@ralfhandl ralfhandl mentioned this pull request Oct 18, 2024
Closed
@ralfhandl ralfhandl requested a review from a team October 18, 2024 08:44
@ralfhandl ralfhandl marked this pull request as ready for review October 18, 2024 14:32
mikekistler
mikekistler approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ralfhandl ralfhandl requested a review from a team October 18, 2024 15:23
@handrews
Copy link
Member

handrews commented Oct 19, 2024

Switching this to draft because I've almost merged it twice now.

@handrews handrews marked this pull request as draft October 19, 2024 18:38
@ralfhandl ralfhandl marked this pull request as ready for review October 22, 2024 15:09
kevinswiber
kevinswiber approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@kevinswiber kevinswiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lornajane lornajane merged commit 8567145 into OAI:gh-pages Oct 22, 2024
@ralfhandl ralfhandl deleted the gh-pages-add-overlay branch October 22, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lornajane lornajane lornajane approved these changes

@mikekistler mikekistler mikekistler approved these changes

+1 more reviewer

@kevinswiber kevinswiber kevinswiber approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Housekeeping

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ralfhandl @handrews @kevinswiber @lornajane @mikekistler