Skip to content

clarifies security requirements wording for 3.1.1 #4123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2024
Merged

clarifies security requirements wording for 3.1.1 #4123

merged 2 commits into from
Oct 10, 2024

Conversation

baywet
Copy link
Contributor

@baywet baywet commented Oct 3, 2024

fixes #4119

@baywet baywet requested a review from a team as a code owner October 3, 2024 17:57
@baywet baywet force-pushed the fix/security-requirements-wording branch from d49203a to b50dd1a Compare October 3, 2024 17:59
This was referenced Oct 3, 2024
Closed
Closed
mikekistler
mikekistler previously approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't find the old wording confusing -- I think it is clear if you read it carefully -- but I don't object to this change.

kevinswiber
kevinswiber reviewed Oct 4, 2024
View reviewed changes
@kevinswiber
Copy link
Contributor

@baywet Thank you for trying to provide additional clarity around this. It's the most complicated part of the spec, IMHO.

ralfhandl
ralfhandl reviewed Oct 7, 2024
View reviewed changes
@ralfhandl ralfhandl modified the milestones: v3.0.4, v3.1.1 Oct 7, 2024
@baywet @ralfhandl @kevinswiber
Apply suggestions from code review
4436e3a 
Co-authored-by: Ralf Handl <[email protected]>
Co-authored-by: Kevin Swiber <[email protected]>
kevinswiber
kevinswiber approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@kevinswiber kevinswiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@miqui miqui requested a review from ralfhandl October 8, 2024 11:41
@handrews handrews added security security: config The mechanics of severs and structure of security-related objects labels Oct 8, 2024
@lornajane lornajane merged commit 5559b5c into OAI:v3.1.1-dev Oct 10, 2024
2 checks passed
@baywet baywet deleted the fix/security-requirements-wording branch October 10, 2024 16:40
@baywet
Copy link
Contributor Author

baywet commented Oct 10, 2024

Thanks everyone for approving and merging!
For others who might be reading and not on the meeting @handrews graciously offered to use a script he built to port it to 3.0.4

@baywet
Copy link
Contributor Author

baywet commented Oct 10, 2024

3.0.4 PR #4129

ralfhandl added a commit that referenced this pull request Oct 10, 2024
@ralfhandl
Merge pull request #4129 from handrews/sec-req-again-304
947cd76 
clarifies security requirements wording for 3.0.4 (port of #4123)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lornajane lornajane lornajane approved these changes

@darrelmiller darrelmiller darrelmiller approved these changes

@ralfhandl ralfhandl ralfhandl approved these changes

@mikekistler mikekistler Awaiting requested review from mikekistler

@handrews handrews Awaiting requested review from handrews

@miqui miqui Awaiting requested review from miqui

@earth2marsh earth2marsh Awaiting requested review from earth2marsh

+1 more reviewer

@kevinswiber kevinswiber kevinswiber approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
security: config The mechanics of severs and structure of security-related objects security
Projects
None yet
Milestone
v3.1.1
Development

Successfully merging this pull request may close these issues.
7 participants
@baywet @kevinswiber @lornajane @darrelmiller @ralfhandl @mikekistler @handrews