Skip to content

3.0.4: replace "property" with "field" or "keyword" where appropriate #4020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2024
Merged

3.0.4: replace "property" with "field" or "keyword" where appropriate #4020

merged 1 commit into from
Aug 15, 2024

Conversation

@ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Aug 15, 2024

Part of

Rules:

  • JSON Schema keywords -> "keyword"
  • OpenAPI fixed fields -> "field"
  • property of a "plain" JSON object that is not an OpenAPI-defined Foo Object -> "property"

@ralfhandl ralfhandl added the editorial Wording and stylistic issues label Aug 15, 2024
@ralfhandl ralfhandl added this to the v3.0.4 milestone Aug 15, 2024
@ralfhandl ralfhandl requested review from a team, handrews, lornajane, mikekistler and miqui August 15, 2024 08:03
@ralfhandl ralfhandl linked an issue Aug 15, 2024 that may be closed by this pull request
Usage of field vs property #2660
Closed
@ralfhandl ralfhandl mentioned this pull request Aug 15, 2024
Closed
@mikekistler mikekistler mentioned this pull request Aug 15, 2024
Merged
mikekistler
mikekistler reviewed Aug 15, 2024
View reviewed changes
lornajane
lornajane approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you¬

mikekistler
mikekistler approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ralfhandl ralfhandl merged commit 3deaba2 into OAI:v3.0.4-dev Aug 15, 2024
@ralfhandl ralfhandl deleted the 3.0.4/property-field-keyword branch August 15, 2024 19:54
This was referenced Aug 16, 2024
Merged
Closed
Merged
@ralfhandl ralfhandl mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lornajane lornajane lornajane approved these changes

@handrews handrews handrews approved these changes

@mikekistler mikekistler mikekistler approved these changes

@miqui miqui Awaiting requested review from miqui

Assignees

No one assigned

Labels

editorial Wording and stylistic issues

Projects

None yet

Milestone

v3.0.4

Development

Successfully merging this pull request may close these issues.

Usage of field vs property

4 participants

@ralfhandl @lornajane @handrews @mikekistler