Skip to content

- adds int16 format #3186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2023
Merged

- adds int16 format #3186

merged 2 commits into from
Mar 16, 2023

Conversation

@baywet
Copy link
Member

@baywet baywet commented Mar 3, 2023

related #3167

@baywet baywet mentioned this pull request Mar 3, 2023
Merged
@handrews
Copy link
Member

handrews commented Mar 6, 2023

@OAI/tsc was there any particular reason int16 wasn't included in the first place?

@MikeRalphson
Copy link
Member

MikeRalphson commented Mar 7, 2023

@OAI/tsc was there any particular reason int16 wasn't included in the first place?

@handrews I think only because it wasn't present in 2.0/3.0 and possibly there was no user issue about it, only data from real-world corpora.

@baywet baywet force-pushed the feature/int-formats branch from 7374428 to d9a9925 Compare March 7, 2023 13:28
MikeRalphson
MikeRalphson reviewed Mar 9, 2023
View reviewed changes
Copy link
Member

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the future versions comment here? int16 isn't in the same category as byte or binary.

baywet
baywet commented Mar 9, 2023
View reviewed changes
@baywet
Copy link
Member Author

baywet commented Mar 9, 2023

Why the future versions comment here? int16 isn't in the same category as byte or binary.

Removed

@baywet
Copy link
Member Author

baywet commented Mar 13, 2023

@darrelmiller I believe this one is good to merge as we've been through all the required updates.

MikeRalphson
MikeRalphson approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baywet baywet mentioned this pull request Mar 14, 2023
Closed
@darrelmiller darrelmiller merged commit 83844b8 into OAI:gh-pages Mar 16, 2023
@baywet baywet deleted the feature/int-formats branch March 16, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@handrews handrews handrews approved these changes

+1 more reviewer

@MikeRalphson MikeRalphson MikeRalphson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

format-registry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@baywet @handrews @MikeRalphson @darrelmiller