Skip to content

Conversation

@usarid
Copy link
Contributor

@usarid usarid commented Jul 20, 2017

Create v2.0 folder, move the files there, and update them to reflect OAS wherever that reflects the up to date name of the spec.

* within the [responses object](https://github.com/swagger-api/swagger-spec/blob/master/versions/2.0.md#responses-object)
* within the [tag object](https://github.com/swagger-api/swagger-spec/blob/master/versions/2.0.md#tag-object)
* within the [security-scheme object](https://github.com/swagger-api/swagger-spec/blob/master/versions/2.0.md#security-scheme-object)
* within the [info object](https://github.com/OAI/OpenAPI-Specification/blob/OpenAPI.next/versions/2.0.md#info-object)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to master instead of OpenAPI.next.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not need to include the branch - just use relative links instead of absolute links, such as :

within the [info object](2.0.md#info-object)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're the file links to the spec versions which are in a different folder, @DavidBiesack , but maybe an absolute path will work (/versions/2.0.md#info-object)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed - changed them to links like /versions/2.0.md#info-object and that seems to work.

# OpenAPI Extensions

The Swagger 2.0 specification allows for custom properties to be added at several places within a Swagger definition, allowing
The OpenAPI Specification version 2.0 allows for custom properties to be added at several places within an OpenAPI definition, allowing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be OpenAPI document

@webron
Copy link
Member

webron commented Jul 21, 2017

Please add extensions.md file at the root of the guidelines folder linking to the moved file under the new directory (to avoid link breakage).

@usarid
Copy link
Contributor Author

usarid commented Jul 25, 2017

Added the EXTENSIONS.md at the root, linking to the one in 2.0.

@webron webron merged commit 1bb321a into OAI:OpenAPI.next Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants