minor edits #1147
Merged
minor edits #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrelmiller
approved these changes
Jun 6, 2017
ePaul
reviewed
Jun 7, 2017
| - Visualization. Can the specification change be graphically visualized somehow in a UI or other interface? | ||
|
|
||
| Spec changes should be approved by a majority of the committers. This can be done by commenting on the issue itself ("Approved by @fehguy" for example). Once voting criteria is met, any committer can merge the PR. (**TODO: we will want to formalize what voting criteria actually is). | ||
| Spec changes should be approved by a majority of the committers. Approval can be given by commenting on the issue itself, for example, "Approved by @fehguy". After voting criteria is met, any committer can merge the PR. (**TODO: we will want to formalize what voting criteria actually is). |
Contributor
There was a problem hiding this comment.
If you are changing this paragraph, could you close the ** here after the TODO? I guess markdown's in-line markup should close itself at the end of the paragraph, but Github's diff view doesn't seem to know this.)
Contributor
webron
approved these changes
Jun 9, 2017
Contributor
|
#TDC Consensus on merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.