Skip to content

Conversation

@NobodyXu
Copy link
Collaborator

Fix #298

@NobodyXu
Copy link
Collaborator Author

cc @Turbo87 Can you try this PR please?
It should fix the error you've encountered.

@NobodyXu NobodyXu requested a review from robjtede October 12, 2024 07:26
@Turbo87
Copy link

Turbo87 commented Oct 12, 2024

just pushed it to our staging environment. it'll take a while to verify that it's actually fixed, but thanks for the very quick response! ❤️

@robjtede robjtede added this pull request to the merge queue Oct 12, 2024
@robjtede
Copy link
Member

lgtm but we can wait for til EoD to release in case @Turbo87 reports any issues

Merged via the queue into main with commit 9d9fe02 Oct 12, 2024
16 checks passed
@robjtede robjtede deleted the Fix/decode branch October 12, 2024 08:39
@Turbo87
Copy link

Turbo87 commented Oct 12, 2024

I pushed Turbo87/crates.io@e6431c9 to our staging environment, but Sentry shows:

Bildschirmfoto 2024-10-12 um 11 17 22

which seems to indicate that the issue still exists or I've messed up the update 😅

@NobodyXu
Copy link
Collaborator Author

Hmmm the branch is auto deleted since it is merged to main.

Maybe you need to use the main branch, or the latest commit hash?

@Turbo87
Copy link

Turbo87 commented Oct 12, 2024

yeah, though when I did the commit the branch was not merged yet and the lockfile includes the commit hash. since you're using proper, non-squash merges here the commit hash should still be resolvable by cargo.

but just in case I'll update it to main and try again 👍

@NobodyXu
Copy link
Collaborator Author

NobodyXu commented Oct 12, 2024

the lockfile includes the commit hash.

Well hmmm I don't know if it would works because I never tried.

Thanks for the retry, let's see if it would fix the issue

@Turbo87
Copy link

Turbo87 commented Oct 12, 2024

I changed it over to Turbo87/crates.io@c58174f, but according to Sentry it's still happening with this deployment too :-/

@NobodyXu
Copy link
Collaborator Author

Thanks, is there any unwinding/panic info?

@Turbo87
Copy link

Turbo87 commented Oct 12, 2024

Bildschirmfoto 2024-10-12 um 12 16 02

basically all I can see is the stacktrace and a bit of metadata, but nothing else related to the panic.

I just deployed rust-lang/crates.io#9639 to the staging environment to double check and that did indeed "fix" the issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panic: cannot consume from pending buffer

4 participants