-
Notifications
You must be signed in to change notification settings - Fork 102
Fix panic when decoding #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
And add back comment Signed-off-by: Jiahao XU <[email protected]>
Also add back comments Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
|
cc @Turbo87 Can you try this PR please? |
|
just pushed it to our staging environment. it'll take a while to verify that it's actually fixed, but thanks for the very quick response! ❤️ |
|
lgtm but we can wait for til EoD to release in case @Turbo87 reports any issues |
|
I pushed Turbo87/crates.io@e6431c9 to our staging environment, but Sentry shows: which seems to indicate that the issue still exists or I've messed up the update 😅 |
|
Hmmm the branch is auto deleted since it is merged to main. Maybe you need to use the main branch, or the latest commit hash? |
|
yeah, though when I did the commit the branch was not merged yet and the lockfile includes the commit hash. since you're using proper, non-squash merges here the commit hash should still be resolvable by cargo. but just in case I'll update it to |
Well hmmm I don't know if it would works because I never tried. Thanks for the retry, let's see if it would fix the issue |
|
I changed it over to Turbo87/crates.io@c58174f, but according to Sentry it's still happening with this deployment too :-/ |
|
Thanks, is there any unwinding/panic info? |
|
basically all I can see is the stacktrace and a bit of metadata, but nothing else related to the panic. I just deployed rust-lang/crates.io#9639 to the staging environment to double check and that did indeed "fix" the issue for now. |


Fix #298