This repository was archived by the owner on Jan 10, 2024. It is now read-only.
Added customization for notification buttons (issue #12) #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey @danielebruni, I'm really sorry that we never got around to merging this PR. It just never appeared in my notifications for some reason 😞 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi and thank you for the work on this plugin. It's really useful.
I wanted to customize buttons in the notification (just like the guy who opened issue 12) so i added some setters for notification manager related properties. I retained your initial values in some DEFAULT_ constants at the top.
I hope I got your coding style right.
Daniele