Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
docker/rootfs/etc/cont-init.d/01_s6-secret-init.sh
to allow parsing of Docker secrets in s6 environment. (feature request: Does Project Support use of Docker Secrets? #818) and add stage2 logging if errorsThis is up and running on dockerhub as ahgraber/nginx-proxy-manager if you'd like to test. The
:test
tag includes debug code to print the secret parsing to docker logs.I'll also be sending a PR to allow
mariadb-aria
to also use docker secrets.full compose stack (mariadb-aria and npm)