set proper timeout. #406
Merged
set proper timeout. #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docker Image for build 1 is available on DockerHub as |
jc21
added
the
requires-verification
|
Docker Image for build 2 is available on DockerHub as |
|
Docker Image for build 3 is available on DockerHub as |
|
Ah crap I closed this instead of merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it makes so nginx can handle connection client <- nginx -> backend for 90 secounds (90s i think is normal and most used timeout limit)
Example if you for backend have apache2 and your timeout is 300s and you try to install some script that take longer then 65s (current conf https://github.com/jc21/nginx-proxy-manager/blob/master/docker/rootfs/etc/nginx/nginx.conf#L29) then nginx will close connection at 65s ignoring apache (backend) 300s timeout and will return 504 err.
server_names_hash_bucket_size 64;->server_names_hash_bucket_size 1024;will increase support for long sub-domain names http://nginx.org/en/docs/http/server_names.html current 64 i think is low