Remove spaces around Cloudflare API Credential #3781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docker Image for build 1 is available on DockerHub as Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes. |
|
This same issue has given me headaches before. This should definitely be added. |
picnicbob
pushed a commit
to picnicbob/nginx-proxy-manager
that referenced
this pull request
Jul 1, 2025
This reverts commit 40f22d3, reversing changes made to f327c1e. Storing user/password instead of an API token is not a good idea and specifically not recommended by certbot-dns-cloudflare documentation. dns_cloudflare_api_token=abc123 was/is working fine for me. Spaces were intentionally removed in the past by NginxProxyManager#3781.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into this same issue multiple times, as the common practice is to simply replace the placeholder token. However, doing so is incorrect syntax.
Proposal is to remove spaces around the
=such that overwriting the placeholder API key with the user's "just works".