Skip to content

Replace distutils.version with packaging.version #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 15, 2022
Merged

Replace distutils.version with packaging.version #1135

merged 4 commits into from
Jul 15, 2022

Conversation

@apdavison
Copy link
Member

@apdavison apdavison commented Jul 5, 2022

fixes #1134

@apdavison apdavison requested a review from JuliaSprenger July 5, 2022 14:44
@apdavison apdavison added this to the 0.11.0 milestone Jul 5, 2022
@samuelgarcia
Copy link
Contributor

samuelgarcia commented Jul 6, 2022

Merci Andrew!
This was an urgent need.

@samuelgarcia
Copy link
Contributor

samuelgarcia commented Jul 6, 2022

This patch make the implementation of neuralynx unhappy...

@apdavison
Copy link
Member Author

apdavison commented Jul 6, 2022

yep, I'm working on that...

@JuliaSprenger
Copy link
Member

JuliaSprenger commented Jul 15, 2022

Thanks for fixing this!

@JuliaSprenger JuliaSprenger merged commit 1644350 into NeuralEnsemble:master Jul 15, 2022
@samuelgarcia samuelgarcia mentioned this pull request Jul 27, 2022
Closed
@apdavison apdavison modified the milestones: 0.10.3, 0.11.0 Aug 30, 2022
@Jai477 Jai477 mentioned this pull request Jul 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuliaSprenger JuliaSprenger Awaiting requested review from JuliaSprenger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.11.0

Development

Successfully merging this pull request may close these issues.

Deprecation Warnings with py3.9/3.10

3 participants

@apdavison @samuelgarcia @JuliaSprenger