-
Notifications
You must be signed in to change notification settings - Fork 265
Implement SpikeTrainList class, and make Segment.spiketrains an instance of this class #1000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SpikeTrainList class, and make Segment.spiketrains an instance of this class #1000
Conversation
|
Hello @apdavison! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-06-28 09:51:52 UTC |
7c65b0c to
fa31634
Compare
0d2aabf to
25021b6
Compare
|
tests all passing now |
|
@apdavison Thanks for the new feature worthy of the 1000th PR / issue :) |
|
@JuliaSprenger that's a good point. We could perhaps generalise ChannelView to index specific spike trains within the SpikeTrainList. |
# Conflicts: # neo/core/spiketrain.py
|
if the tests all pass, this is ready to merge, I think |
…_stop required to match SpikeTrain.__init__
and fix some typos in documentation
Please note that the internal implementation can probably be improved/optimised, but that is likely to need some profiling.
The general idea is to create SpikeTrain objects only when necessary, and to provide the "multiplexed" property to allow treating spike trains directly as (spike_time_array, channel_id_array)