Skip to content

use ISO8601 for normalized filenames #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 11, 2020
Merged

use ISO8601 for normalized filenames #695

merged 3 commits into from
Dec 11, 2020

Conversation

@laurentperrinet
Copy link
Contributor

@laurentperrinet laurentperrinet commented Dec 2, 2020

  • making it optional
  • it is False by default to not change the behavior

@laurentperrinet
use ISO8601 for normalized filenames
f815e91 
* making it optional
* it is False by default to not change the behavior
@coveralls
Copy link

coveralls commented Dec 2, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 51.666% when pulling ec39915 on SpikeAI:master into 002e36f on NeuralEnsemble:master.

@laurentperrinet
Update __init__.py
becbfdf 
trailing coma
@apdavison
Copy link
Member

apdavison commented Dec 8, 2020

Many thanks @laurentperrinet

Please could you change the argument name to "use_iso8601"?

@apdavison apdavison added this to the 0.9.6 milestone Dec 8, 2020
@laurentperrinet
Copy link
Contributor Author

laurentperrinet commented Dec 10, 2020

hi @apdavison
good suggestion, I have made that change.
cheers, Laurent

@apdavison apdavison merged commit 72e8276 into NeuralEnsemble:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

0.9.6

Development

Successfully merging this pull request may close these issues.

3 participants

@laurentperrinet @coveralls @apdavison