Skip to content

Conversation

benjasper
Copy link

Somehow the closing of the "Neogit console" float recently stopped working in the context of running pre-commit hooks, preventing me from seeing the commit buffer (I am using a split for the commit view).

The problem can be easily reproduced by putting something long running with output into the commit-hook that returns fine with exit code 0. And then try to commit.
For Example

for i in {1..10}; do
    echo "Waiting $i seconds..."
    sleep 1
done

I am not really sure as to the root cause of this issue, because i am very sure that this worked at some point, but couldn't find a commit where this worked.

If you have any input or would like me to make changes let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant