fix: fixed auto_close_console not working for pre-commit hooks #1841
+18
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow the closing of the "Neogit console" float recently stopped working in the context of running pre-commit hooks, preventing me from seeing the commit buffer (I am using a split for the commit view).
The problem can be easily reproduced by putting something long running with output into the commit-hook that returns fine with exit code 0. And then try to commit.
For Example
I am not really sure as to the root cause of this issue, because i am very sure that this worked at some point, but couldn't find a commit where this worked.
If you have any input or would like me to make changes let me know!