Allow interactive rebase to root commit

[Silex]

When you ri to the very first commit, magit detects this and automatically adds --root to the interactive rebase.

[CKolkey]

I think I tried to copy the logic, but perhaps didn't get it right:

neogit/lua/neogit/popups/rebase/actions.lua

Lines 63 to 82 in 2956183

	function M.interactively(popup)
	local commit
	if popup.state.env.commit then
	commit = popup.state.env.commit
	else
	commit = CommitSelectViewBuffer.new(git.log.list()):open_async()[1]
	end
	if commit then
	local args = popup:get_arguments()
	local parent_commit = git.cli["rev-list"].max_count(1).parents.args(commit).call().stdout[1]
	if commit ~= parent_commit then
	commit = vim.split(parent_commit, " ")[2]
	else
	table.insert(args, "--root")
	end
	git.rebase.rebase_interactive(commit, args)
	end
	end

[star-szr]

I worked on this in #883 and it should already work as the issue is describing.

[Silex]

When I ri on the root commit I get an interactive rebase that contains only the root commit.

It should contain the root AND child commits.

[star-szr]

I’m not sure what to suggest, I’ve never used Magit but I did refer to their logic for this functionality and as far as I know we pass --root in the same situations as Magit.

Maybe there is some special handling on top of this in Magit? I don’t really understand the use case though and why you wouldn’t just rebase the child, could you explain a bit more?

Just speaking of git to my knowledge all the root flag does is allow you to rebase the root commit (otherwise you will see an error if I recall correctly).

[CKolkey]

I think i sorted this out. Should have an update out soon. I think the issue is that you can pass the --root flag, OR a commit hash, but not both.