Add support for discard in visual mode

[Shatur]

Is your feature request related to a problem? Please describe.
Unlike stage, discard (x) currently works only in normal mode.

Describe the solution you'd like
It would be nice if discard could work in visual mode, like stage/unstage.
This is how it works in fugitive.

[star-szr]

This is working for me, possibly fixed by 70fb5ce?

I poked around a bit and notice that

neogit/lua/neogit/status.lua

Lines 831 to 845 in 08d23c7

	---Discards selected lines
	local function discard_selection(section, item, hunk, from, to)
	logger.debug("Discarding selection hunk:" .. vim.inspect(hunk))
	local patch = git.index.generate_patch(item, hunk, from, to, true)
	logger.debug("Patch:" .. vim.inspect(patch))
	if section.name == "staged" then
	local result = git.index.apply(patch, { reverse = true, index = true })
	if result.code ~= 0 then
	error("Failed to discard" .. vim.inspect(result))
	end
	else
	git.index.apply(patch, { reverse = true })
	end
	end

has not changed recently.

[Shatur]

Hm... Doesn't work for me. x in visual mode does nothing.

[star-szr]

Could you give more details as to what you have selected? I tested by selected lines but maybe you have selected a file or hunk header for example.

[ten3roberts]

Would this be fixed if you check out #777?

It is not fully done, but aims to refactor the visual selection amd normal mode logic for stage/unstage/discard and make then all consistent

[Shatur]

selected a file or hunk header for example.

Yes, this is exactly what I select.

Would this be fixed if you check out #777?

Yes, this is just what I need! I tried it out, it doesn't work work line by line as unstage, but allows me to select multiple hunks at least.

[ten3roberts]

Yes. Currently fixing that now, as well as making sure everything else works.

This change also allows selection across sections, or files and hunks