fix: tns update command should work with npm tags
#5213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past `tns update` command worked with tags, but since 6.0 this was broken. The logic in Update Controller requires a valid package.json from template with same version. However, our templates do not have `next`, `rc`, etc. versions and passing tag to the command fails. In order to fix this, construct the required template manually. For each of the packages we would update, check if the has a valid version with the same tag and get the current version behind this tag.
|
test cli-smoke |
|
test cli-smoke |
DimitarTachev
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past
tns updatecommand worked with tags, but since 6.0 this was broken. The logic in Update Controller requires a valid package.json from template with same version. However, our templates do not havenext,rc, etc. versions and passing tag to the command fails.In order to fix this, construct the required template manually. For each of the packages we would update, check if the has a valid version with the same tag and get the current version behind this tag.
PR Checklist
What is the current behavior?
tns update nextfails.What is the new behavior?
tns update nextpasses.Fixes issue #5072