-
-
Notifications
You must be signed in to change notification settings - Fork 197
Reimplement livesync #2883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Reimplement livesync #2883
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
9b83cda
WIP
nadyaA 33d79ab
Move OS compatibility check to commands
nadyaA 8ccf75f
New LiveSync
rosen-vladimirov a0f037e
WIP
rosen-vladimirov 33371a4
WIP next
rosen-vladimirov 19b7fca
Add useLiveEdit option
rosen-vladimirov 1765397
Update Public API interfaces
rosen-vladimirov 823f1c5
Add events for LiveSync
rosen-vladimirov f45f1e3
Add correct events for LiveSync
rosen-vladimirov cd7f808
Add docs and improve liveSync operations when called multiple times f…
rosen-vladimirov e293ef9
Fix liveSync - add correct check for deviceDescriptors
rosen-vladimirov 2c4d0c9
Delete AndroidAppIdentifier
b3b7df8
Remove device-path-provider
4aafecc
Fix multiple rebuilds for the same platform
rosen-vladimirov 6b3662d
Fix unit tests
rosen-vladimirov 0f9c0aa
Extract all common logic of livesync services to platform-livesync-se…
rosen-vladimirov 4dfc040
Remove livesync-provider
rosen-vladimirov 3a38e78
Add notify event during LiveSync
rosen-vladimirov 869c95a
Rename error event to liveSyncError
rosen-vladimirov 96af540
Do not kill ios-device-lib in `tns run`
rosen-vladimirov 4d6b990
WIP
TsvetanMilanov f11d405
Expose saveBuildInfoFile
4eb8d7f
Fix always reinstalling apps during livesync
rosen-vladimirov 4bb0330
Minor bugfixes
e6c2821
Move notification service to common
4e4197e
Fix Success livesync and run fail messages
e377340
Implement tracking
75578ea
Fix lint errors
03f0537
Fix message for tests
e2205c6
Fix comments vol. I
82ba18f
Cache sockets per app per device
rosen-vladimirov 013c5fa
Fix run
714275c
Fix run not starting emulator
64080f7
Pass emulator flag and fix process.platform messages
c6127ea
Fix chrome debug message
f32f243
Do not determine dynamic dependencies on Windows
nadyaA 5b1141c
Restart app upon debugging
0acb22d
Update common to latest master
baab31b
Remove obsolete vendor directory
7b2f1ab
Fix run with --release and --clean
f3dc66e
Fix unit tests
rosen-vladimirov b4b4232
Fix debug-service unit tests
rosen-vladimirov b74d44d
Update ios-device-lib to 0.4.4
rosen-vladimirov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the whole class is public ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it is an
EventEmitter