Skip to content

Change livesync dir permissions on device even if app is not restarted #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Change livesync dir permissions on device even if app is not restarted #2708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/common
Open in desktop
Submodule common updated 2 files
+5 −2 mobile/android/android-device-file-system.ts
+1 −1 mobile/mobile-core/android-process-service.ts
10 changes: 8 additions & 2 deletions lib/services/livesync/android-device-livesync-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,14 @@ class AndroidLiveSyncService implements INativeScriptDeviceLiveSyncService {
}

public async refreshApplication(deviceAppData: Mobile.IDeviceAppData, localToDevicePaths: Mobile.ILocalToDevicePathData[], forceExecuteFullSync: boolean, projectData: IProjectData): Promise<void> {
await this.device.adb.executeShellCommand(
["chmod",
"777",
await deviceAppData.getDeviceProjectRootPath(),
`/data/local/tmp/${deviceAppData.appIdentifier}`,
`/data/local/tmp/${deviceAppData.appIdentifier}/sync`]
);

let canExecuteFastSync = !forceExecuteFullSync && !_.some(localToDevicePaths, (localToDevicePath: any) => !this.$liveSyncProvider.canExecuteFastSync(localToDevicePath.getLocalPath(), projectData, deviceAppData.platform));

if (canExecuteFastSync) {
Expand All @@ -31,8 +39,6 @@ class AndroidLiveSyncService implements INativeScriptDeviceLiveSyncService {
}

private async restartApplication(deviceAppData: Mobile.IDeviceAppData): Promise<void> {
await this.device.adb.executeShellCommand(["chmod", "777", await deviceAppData.getDeviceProjectRootPath(), `/data/local/tmp/${deviceAppData.appIdentifier}`]);

let devicePathRoot = `/data/data/${deviceAppData.appIdentifier}/files`;
let devicePath = this.$mobileHelper.buildDevicePath(devicePathRoot, "code_cache", "secondary_dexes", "proxyThumb");
await this.device.adb.executeShellCommand(["rm", "-rf", devicePath]);
Expand Down