fix: Do not update in-place object prototypes (#67) #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as abuse.
This comment was marked as abuse.
darind
force-pushed
the
darind/register-additional-protocols-fix
branch
from
964d394 to
71ffa0d
Compare
|
@NathanaelA, very good catch! Thanks for verifying. I pushed an additional commit which should address this issue. Can you check it now? By the way, I saw that there are 4 failing tests on iOS 14 and a crash on iOS 10.3 with the official runtime from the |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #67
This PR addresses an issue where we replace the existing object prototype with additional protocols returned from pseudo types. Instead of modifying the prototype chain, we build an entirely new chain containing the additional protocols.