-
Notifications
You must be signed in to change notification settings - Fork 201
CI: Enable proxy cache in test and build-docs pipelines #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: leofang <[email protected]>
/ok to test 6325eb8 |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot looking good! Could you please also add the same action to this workflow .github/workflows/build-docs.yml
? There's a TODO on caching which would become obsolete if we set up the proxy.
…ix formatting Co-authored-by: leofang <[email protected]>
Added the setup-proxy-cache action to build-docs.yml workflow and removed the obsolete TODO about conda caching since the proxy cache addresses package download performance. 77d14da |
/ok to test 77d14da |
# TODO: cache conda env to speed up the workflow once conda-incubator/setup-miniconda#267 | ||
# is resolved | ||
- name: Setup proxy cache | ||
uses: nv-gha-runners/setup-proxy-cache@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we pin this to a specific commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry Keith, I set automerge so did not get a chance to reply before merging. I think the bot just followed what Marcus did earlier. It seems everyone pins at main too: https://github.com/search?q=setup-proxy-cache+language%3Ayaml+NOT+is%3Afork&type=code
@@ -143,6 +143,10 @@ jobs: | |||
with: | |||
fetch-depth: 0 | |||
|
|||
- name: Setup proxy cache | |||
uses: nv-gha-runners/setup-proxy-cache@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
This PR adds the
setup-proxy-cache
step to test workflows and the build-docs workflow as a follow-up to PR #555, which originally added proxy caching to build workflows. The proxy cache improves Python package download times during testing and documentation builds by caching packages closer to the runners.Changes Made
Added the
setup-proxy-cache
step to workflows:.github/workflows/test-wheel-linux.yml
- Added proxy cache setup (Linux-only, no conditional logic needed).github/workflows/test-wheel-windows.yml
- Added TODO comment for future Windows runner support.github/workflows/build-docs.yml
- Added proxy cache setup to speed up conda/pip package downloadsThe implementation follows the exact same pattern established in PR #555:
Key Features
continue-on-error: true
to ensure cache failures don't break pipelinesBenefits
Fixes #812.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.