Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Aug 20, 2025

This PR adds the setup-proxy-cache step to test workflows and the build-docs workflow as a follow-up to PR #555, which originally added proxy caching to build workflows. The proxy cache improves Python package download times during testing and documentation builds by caching packages closer to the runners.

Changes Made

Added the setup-proxy-cache step to workflows:

  • .github/workflows/test-wheel-linux.yml - Added proxy cache setup (Linux-only, no conditional logic needed)
  • .github/workflows/test-wheel-windows.yml - Added TODO comment for future Windows runner support
  • .github/workflows/build-docs.yml - Added proxy cache setup to speed up conda/pip package downloads

The implementation follows the exact same pattern established in PR #555:

- name: Setup proxy cache
  uses: nv-gha-runners/setup-proxy-cache@main
  continue-on-error: true

Key Features

  • Consistent with build workflows: Uses identical action reference and error handling
  • Proper placement: Added after checkout but before any dependency installation steps
  • Platform-aware: Linux workflows use proxy cache, Windows workflow includes TODO for future support
  • Fail-safe: Uses continue-on-error: true to ensure cache failures don't break pipelines
  • Documentation builds: Speeds up conda environment setup and package installations

Benefits

  • Faster test execution due to reduced Python package download times
  • Improved reliability for test pipelines that download lots of wheels
  • Faster documentation builds with reduced conda package download times
  • Consistent caching strategy across build, test, and documentation workflows

Fixes #812.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Contributor

copy-pr-bot bot commented Aug 20, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Copilot Copilot AI changed the title [WIP] CI: Enable the proxy cache in test pipelines CI: Enable proxy cache in test pipelines Aug 20, 2025
@Copilot Copilot AI requested a review from leofang August 20, 2025 18:58
Copilot finished work on behalf of leofang August 20, 2025 18:58
@github-project-automation github-project-automation bot moved this from Todo to In Progress in CCCL Aug 20, 2025
@leofang
Copy link
Member

leofang commented Aug 20, 2025

/ok to test 6325eb8

@leofang leofang marked this pull request as ready for review August 20, 2025 19:48
@leofang leofang added the CI/CD CI/CD infrastructure label Aug 20, 2025

This comment has been minimized.

Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot looking good! Could you please also add the same action to this workflow .github/workflows/build-docs.yml? There's a TODO on caching which would become obsolete if we set up the proxy.

Copy link
Contributor Author

Copilot AI commented Aug 20, 2025

@copilot looking good! Could you please also add the same action to this workflow .github/workflows/build-docs.yml? There's a TODO on caching which would become obsolete if we set up the proxy.

Added the setup-proxy-cache action to build-docs.yml workflow and removed the obsolete TODO about conda caching since the proxy cache addresses package download performance. 77d14da

@Copilot Copilot AI changed the title CI: Enable proxy cache in test pipelines CI: Enable proxy cache in test and build-docs pipelines Aug 20, 2025
Copilot finished work on behalf of leofang August 20, 2025 22:04
@Copilot Copilot AI requested a review from leofang August 20, 2025 22:04
@leofang
Copy link
Member

leofang commented Aug 20, 2025

/ok to test 77d14da

@leofang leofang added enhancement Any code-related improvements P1 Medium priority - Should do labels Aug 20, 2025
@leofang leofang added this to the cuda.core beta 7 milestone Aug 20, 2025
@leofang leofang enabled auto-merge (squash) August 20, 2025 22:10
@leofang leofang requested a review from cryos August 20, 2025 22:42
# TODO: cache conda env to speed up the workflow once conda-incubator/setup-miniconda#267
# is resolved
- name: Setup proxy cache
uses: nv-gha-runners/setup-proxy-cache@main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pin this to a specific commit?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry Keith, I set automerge so did not get a chance to reply before merging. I think the bot just followed what Marcus did earlier. It seems everyone pins at main too: https://github.com/search?q=setup-proxy-cache+language%3Ayaml+NOT+is%3Afork&type=code

@@ -143,6 +143,10 @@ jobs:
with:
fetch-depth: 0

- name: Setup proxy cache
uses: nv-gha-runners/setup-proxy-cache@main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@leofang leofang merged commit 51ec60b into main Aug 21, 2025
95 of 96 checks passed
@leofang leofang deleted the copilot/fix-812 branch August 21, 2025 01:13
@github-project-automation github-project-automation bot moved this from In Progress to Done in CCCL Aug 21, 2025
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD infrastructure enhancement Any code-related improvements P1 Medium priority - Should do
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

CI: Enable the proxy cache in test pipelines
3 participants