Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Nov 18, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated integration test skip list to modify test coverage for various model configurations and runtime scenarios.

@xinhe-nv xinhe-nv marked this pull request as ready for review November 18, 2025 02:21
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251118_LLM_FUNCTION_TEST_1649 branch from a433474 to 90a5170 Compare November 18, 2025 02:21
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 18, 2025

📝 Walkthrough

Walkthrough

This PR updates the test waiver list by removing three SKIP entries for DeepEPLowLatency/DeepEP/MNNVL fused_moe alltoall tests and adding two SKIP entries for qwen and Nemotron test cases.

Changes

Cohort / File(s) Summary
Test Waiver List Updates
tests/integration/test_lists/waives.txt
Removed 3 SKIP entries for fused_moe alltoall tests (DeepEPLowLatency, DeepEP, MNNVL variants); added 2 SKIP entries for test_qwen_int4_single_gpu_summary and Nemotron Nano 12B VL auto dtype test

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • This is a straightforward modification to a test waiver list file with simple additions and removals of SKIP entries.

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly
  • jieli-matrix

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is extremely minimal and lacks required sections from the template such as detailed explanation, test coverage, and a completed PR checklist. Expand the description to include: detailed explanation of which failed cases are being waived and why, test coverage information, and completion of the PR checklist items as appropriate.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding failed test cases to the waives.txt file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fc088e6 and 90a5170.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (1 hunks)
🧰 Additional context used
🧠 Learnings (7)
📓 Common learnings
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.
📚 Learning: 2025-09-17T02:48:52.732Z
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-07-22T08:33:49.109Z
Learnt from: yiqingy0
Repo: NVIDIA/TensorRT-LLM PR: 5198
File: jenkins/mergeWaiveList.py:0-0
Timestamp: 2025-07-22T08:33:49.109Z
Learning: In the TensorRT-LLM waive list merging system, removed lines are always located at the end of the merge waive lists, which is why the mergeWaiveList.py script uses reverse traversal - it's an optimization for this specific domain constraint.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-29T14:07:45.863Z
Learnt from: EmmaQiaoCh
Repo: NVIDIA/TensorRT-LLM PR: 7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-09-09T09:40:45.658Z
Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
Repo: NVIDIA/TensorRT-LLM PR: 6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
Repo: NVIDIA/TensorRT-LLM PR: 7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").

Applied to files:

  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/integration/test_lists/waives.txt (1)

423-424: Format and structure look good.

Both new waiver entries follow the established pattern in the file: test path with fully-qualified names, parameters in brackets, SKIP keyword, and bug reference. The nvbugs references are properly formatted and match the convention used throughout the file. Based on learnings, having these tests in both waives.txt and other test list files is intentional and expected for test suite coverage.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24827 [ run ] triggered by Bot. Commit: 90a5170

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24827 [ run ] completed with state SUCCESS. Commit: 90a5170
/LLM/main/L0_MergeRequest_PR pipeline #18740 (Partly Tested) completed with status: 'SUCCESS'

@xinhe-nv xinhe-nv enabled auto-merge (squash) November 19, 2025 01:55
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251118_LLM_FUNCTION_TEST_1649 branch from 6953fb8 to 9929237 Compare November 19, 2025 02:04
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24969 [ reuse-pipeline ] triggered by Bot. Commit: 9929237

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251118_LLM_FUNCTION_TEST_1649 branch from 9929237 to 510f284 Compare November 19, 2025 02:19
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24972 [ reuse-pipeline ] triggered by Bot. Commit: 510f284

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24969 [ reuse-pipeline ] completed with state ABORTED. Commit: 9929237
Can't reuse PR_Github #24827 (Partly Tested) with status: SUCCESS

Signed-off-by: xinhe-nv <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251118_LLM_FUNCTION_TEST_1649 branch from 510f284 to abcad20 Compare November 19, 2025 02:34
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24974 [ reuse-pipeline ] triggered by Bot. Commit: abcad20

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24972 [ reuse-pipeline ] completed with state ABORTED. Commit: 510f284
Can't reuse PR_Github #24827 (Partly Tested) with status: SUCCESS

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24974 [ reuse-pipeline ] completed with state SUCCESS. Commit: abcad20
Reusing PR_Github #24827 (Partly Tested) for commit abcad20

@xinhe-nv xinhe-nv merged commit 286ace2 into NVIDIA:main Nov 19, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20251118_LLM_FUNCTION_TEST_1649 branch November 19, 2025 04:27
lkomali pushed a commit to lkomali/TensorRT-LLM that referenced this pull request Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants