Fix top_k type (float => int32) executor.py #1329
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @vonjackustc , can you please resolve the conflicts so that I can merge this PR? Alternatively, we have integrated your fix to the internal codebase, and the fix will be included in the next update to the GitHub main branch. It's okay if you don't resolve the conflicts by then, we will close this PR and credit you as co-author in the PR that include your changes. Thanks a lot for your support! |
Merged
Member
|
The changes are integrated in PR #1639 and we've credited you as co-author, I'm closing this PR now. Let me know if you have any questions. Thanks a lot for your support and help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For runtime_top_k, the type should be torch.int32.
I meet exception during examples/apps/flaskapi_server.py testing.