Skip to content

Conversation

jaredmauch
Copy link
Contributor

  • The fedora build includes PIE and this is an attempt to preserve that behavior when building NSD, not sure if this will cause a specific problem for other use cases, but wanted to contribute this upstream
  • Makefile - follow dependencies of object files so we will rebuild if the Makefile is updated with -fPIE for example

@wcawijngaards
Copy link
Member

The ci fails because the m4 script is not available. This needs to be imported to the repo. Otherwise the change is a nice feature. I think makefile dependencies on changes to the makefile are probably not so good, there already was trouble, due to the simd variability, in the makefile to build the dependencies too often, but perhaps but this change is not bad for that. Probably harmless, but makefile changes is not the mechanism I am looking to add to the build system. I can merge it though, it needs a couple of fixes with that.

@wcawijngaards wcawijngaards merged commit e132125 into NLnetLabs:main Jul 9, 2025
1 of 6 checks passed
wcawijngaards added a commit that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants