Fix/lint workflow 192 #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing workflow" This reverts commit 0510438.
|
Nice! That seems like it could really help a lot with development. |
|
We now have merged some major changes to the testing configuration. Could you please resolve the conflicts and have another look? |
|
I've looked through the workflows again and made some changes. |
widhalmt
approved these changes
Aug 22, 2023
ivareri
pushed a commit
to ivareri/ansible-collection-elasticstack
that referenced
this pull request
Jun 17, 2025
Fix NETWAYS#192. This PR introduces a reusable workflow. This general workflow handles the job necessary to run both `ansible-lint` and `yamllint` on **either** all roles or one specific role. All roles are linted when: - linting rules are changed - the linting workflow is changed Specific roles are linted when: - a role specific workflow is triggered (linting as first job) - the `full_stack` workflow is triggered (linting as first job) The workflow for the specific role now uses a call to the general linting workflow, while providing it with its own role name. This approach does not completely remove linting from single workflows, but it makes those linting jobs much more readable and reduces redundant code, while also allowing for a bit more flexibility. --------- Co-authored-by: Thomas Widhalm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #192.
This PR introduces a reusable workflow. This general workflow handles the job necessary to run both
ansible-lintandyamllinton either all roles or one specific role.All roles are linted when:
Specific roles are linted when:
full_stackworkflow is triggered (linting as first job)The workflow for the specific role now uses a call to the general linting workflow, while providing it with its own role name.
This approach does not completely remove linting from single workflows, but it makes those linting jobs much more readable and reduces redundant code, while also allowing for a bit more flexibility.