This repository was archived by the owner on Jun 5, 2019. It is now read-only.
Change OneWire API to use a logical port number #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ORTNUM-1 OneWire constructor extended to accept a logical pin number in the range 0..MAX_PORTNUM-1 and check in range in subsequint calls to avoid reference outside array bounds.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OneWire constructor extended to accept both a logical port number in the range 0..MAX_PORTNUM-1, and a physical IO Port.
Physical I/O Output pin number stored in an internal array indexed by the logical port number.
Logical port number checked to be in range. Further calls to OneWire API expect logical port number, which is used to look up physical I/O port number.
Fixes issue noted in NetMF Codeplex: