Skip to content

Conversation

@pyoor
Copy link
Member

@pyoor pyoor commented Jul 29, 2020

No description provided.

@pyoor pyoor requested a review from jschwartzentruber July 29, 2020 20:11
@pyoor
Copy link
Member Author

pyoor commented Jul 29, 2020

@jschwartzentruber these test failures are related to pytest-dev/pytest#7565. Do you want me to pin the version or leave it as is until this lands?

@jschwartzentruber
Copy link
Collaborator

@jschwartzentruber these test failures are related to pytest-dev/pytest#7565. Do you want me to pin the version or leave it as is until this lands?

Nope, not our fault.

This was causing intermittent test failures on py27 and py35 where
dictionary iteration order is random.
@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #73 into master will increase coverage by 0.93%.
The diff coverage is 90.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   57.02%   57.95%   +0.93%     
==========================================
  Files           5        5              
  Lines         719      735      +16     
==========================================
+ Hits          410      426      +16     
  Misses        309      309              
Impacted Files Coverage Δ
src/fuzzfetch/fetch.py 63.63% <90.62%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4acc2bf...02a248b. Read the comment docs.

@pyoor pyoor merged commit 452f1ea into master Jul 31, 2020
@pyoor pyoor deleted the check-build-date branch July 31, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants