Skip to content

HADOOP-JIRA_ID. Fixed an unhandled NullPointerException in class KeyProvider #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from
Open

HADOOP-JIRA_ID. Fixed an unhandled NullPointerException in class KeyProvider #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
62c8069
Bug Found, Fixed and updated comment
monilnarang1 Sep 16, 2022
627ba73
minor fix
monilnarang1 Sep 16, 2022
f59ab37
exception message update
monilnarang1 Sep 16, 2022
0fa3a0f
minor
monilnarang1 Sep 16, 2022
51e7168
updated an existing test to verify the bug
monilnarang1 Sep 28, 2022
e53a019
updated the assert message as per the class
monilnarang1 Sep 28, 2022
6a00139
updated as per comments
monilnarang1 Oct 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/KeyProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,13 +639,16 @@ public void invalidateCache(String name) throws IOException {
public abstract void flush() throws IOException;

/**
* Split the versionName in to a base name. Converts "/aaa/bbb/3" to
* Split the versionName in to a base name. Converts "/aaa/bbb@3" to
* "/aaa/bbb".
* @param versionName the version name to split
* @return the base name of the key
* @throws IOException raised on errors performing I/O.
*/
public static String getBaseName(String versionName) throws IOException {
if (!Objects.nonNull(versionName)) {
throw new NullPointerException("key path variable versionName found null");
}
int div = versionName.lastIndexOf('@');
if (div == -1) {
throw new IOException("No version in key path " + versionName);
Expand Down
3 changes: 3 additions & 0 deletions ...mon-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/key/TestKeyProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import java.util.List;
import java.util.Map;

import static org.apache.hadoop.test.LambdaTestUtils.intercept;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
Expand All @@ -62,6 +63,8 @@ public void testParseVersionName() throws Exception {
} catch (IOException e) {
assertTrue(true);
}
intercept(NullPointerException.class, () ->
KeyProvider.getBaseName(null));
}

@Test
Expand Down