-
Notifications
You must be signed in to change notification settings - Fork 46
[Misc] add store intf with tensor addr ptr #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mag1c-h The semantics of the offset and size params kind of overlap here. Host–Storage transfers are already defined to operate on a page/block basis. Plz consider whether it really makes sense to expose this flexibility to the upper inference engines. |
@pyxyzc For the following reasons, we need to expose both offset and size parameters in the interface:
|
|
do we really need two api here? i think fetch data is what we need final |
They share the same impl, but keeping both API saves every caller a rewrite. |
* add store intf with tensor addr ptr * fix interface doxy
This reverts commit ff76feb.
Purpose
The C++ base class in Store already takes a raw pointer, now add the same pointer-based API to the Python base class to keep it extension-friendly.
Modifications
Add new pointer-based API to the Store Python base class.
Test
CI passed with new added/existing test.