Skip to content

Conversation

@LFSaw
Copy link
Member

@LFSaw LFSaw commented Jul 5, 2017

(see #304)

@LFSaw LFSaw requested a review from adcxyz July 5, 2017 16:44
@LFSaw LFSaw added this to the Release 0.2.5 milestone Jul 5, 2017
Copy link
Contributor

@adcxyz adcxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!
could also be used to simplify the postElements method.

@adcxyz adcxyz merged commit 1fe9053 into ModalityTeam:master Jul 6, 2017
@LFSaw
Copy link
Member Author

LFSaw commented Jul 7, 2017

yepp, was thinking the same... but wanted to first do this one before going into concrete usages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants