Add MIDI control 14 bit support

[sensestage]

This will fix issue #293

[LFSaw]

anyone with a 14bit midi controller at hand to cross-check this?
@miguel-negrao ?

[sensestage]

The BCF2000 can be configured to have 14 bit :)

[sensestage]

It has been tested with both an adapted BCF2000 and the Tascam device

[LFSaw]

I'd like to have a cross-check... and I don;t have a 14bit controller :/

[sensestage]

sure :)

[redFrik]

just an idea... can't you test with maxmsp and the xbendout object? that's 14bit. or ableton or similar program?

[sensestage]

cc 14 bit has a particular way of coupling a CC number with another CC number 32 values up.
So CC 1 and 33, CC 10 and 42, etc.
Pitchbend is a different case.

[sensestage]

One could fake of course with the MIDIOut.control14 method I made, but that would be testing with the same implementation ;)

[LFSaw]

AFAIK, we'd need a third person testing the implementation still...

[LFSaw]

Thanks for the documentation of the features!
I'd prefer to have such detailed info not obstructing the spec (i.e. what is read in to SC3), though. Maybe add the majority of the text to the end of the file, or to a separate document, e.g. in the DeviceExamples directory?

[sensestage]

We could move it to the end, no problem.

I considered to do it as testCode, but I did not quite figure out the syntax for that.

[LFSaw]

Do we really need two separate classes for this? it seems to me an unnecessary clutter of the ClassTable...

[sensestage]

Hmmm... I guess it could be combined, if we make lobyte or hibyte an instance variable that is set on creation.
(of course, then I will need to figure out a testing scenario again as I am no longer close to the device).

[LFSaw]

@sensestage, would you mind to comment?
@miguel-negrao would you mind to test the implementation?

then we can include it to 0.2.0

[miguel-negrao]

Hi

I'm very much interested in this feature. Unfortunately my understanding is that for the BCR to increase its precision just means that the knob rotates slower, so the internal sensors probably have low precision. In any case even if that is true this is useful.
I'll try to test this soon.

[ghost]

Hi

I see plenty of advantages in merging this issue with the main repository. i tested it using Pd-Extended and Ableton, and for me it felt pretty solid. I think we should definitely go into merging this with the central repository, as soon as more people have tested it, because on my standing point increasing resolution communication for any protocol in supercollider, is a most valuable thing for any user, specially as protocol implementations tend to develop and become more solid. So, my big thumbs up to merging this issue

[LFSaw]

@tiagmoraismorgado thanks for your reply! did you test the implementation and found it stable? Since there seems to be no other person with a 14bit controller, I'd then do not see an issue merging it into master. Maybe @sensestage could have a look/comment on my review, though...

[sensestage]

@miguel-negrao The faders of the BCF can also be configured to be 14 bit. The effective resolution is 10 bit though.

[ghost]

@LFSaw i tested it with MaxMSP and Ableton. Big thumbs up to @sensestage

[LFSaw]

I am curious, can you share the patch(es) you used in Max/MSP or Ableton? Those would be good starting-points for external testing of functionality.
Maybe as a gist...

[ghost]

maybe later

[ghost]

i think this feature should be merged to supercollider main repository as part of MIDIDef class. congratulations to Modality team for implementing such a feature

[miguel-negrao]

@tiagmoraismorgado can you please only use header text for actual headers ? It's quite annoying to read whole sentences in huge font size...

[LFSaw]

so how do we progress on this? we have tests by a non-modality-member through Ableton/Max with patches he has not yet shared, and no-one else willing/being able to test. Should we just merge and hope for the best?

[miguel-negrao]

Tested on my BCR with a knob set to NRPN mode, Absolute 14 bit (see manual ) and it seems to work. It should be documented that the cc number to put on the spec is the one with the hi bits.

Note: this is not very useful with the BCR encoders because in 14bit mode it just rotates the encoders slower...