Added support for components for webhooks #56
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinnDevelopment
requested changes
Jan 14, 2022
| } | ||
| return builder.addFormDataPart("payload_json", json).build(); | ||
| } | ||
| System.out.println("json.toString() = " + json.toString()); |
| */ | ||
| public boolean isEmpty() { | ||
| return content.length() == 0 && embeds.isEmpty() && getFileAmount() == 0; | ||
| return content.length() == 0 && embeds.isEmpty() && components.isEmpty() && getFileAmount() == 0; |
Owner
There was a problem hiding this comment.
Components are not a full message, this check is wrong.
| * If more than {@value LayoutComponent#MAX_COMPONENTS} are added | ||
| */ | ||
| @NotNull | ||
| public WebhookMessageBuilder addComponents(LayoutComponent... components) { |
Owner
There was a problem hiding this comment.
This is missing annotations for parameters
| public WebhookMessageBuilder addComponents(LayoutComponent... components) { | ||
| Objects.requireNonNull(components, "Components"); | ||
| if (this.components.size() + components.length > 5) | ||
| throw new IllegalStateException("Cannot have more than 5 action rows in a message"); |
Owner
There was a problem hiding this comment.
Suggested change
| throw new IllegalStateException("Cannot have more than 5 action rows in a message"); | |
| throw new IllegalStateException("Cannot have more than 5 component layouts in a message"); |
| @NotNull | ||
| public WebhookMessageBuilder addComponents(LayoutComponent... components) { | ||
| Objects.requireNonNull(components, "Components"); | ||
| if (this.components.size() + components.length > 5) |
Owner
There was a problem hiding this comment.
This should be a constant
| * @param value The dev-defined value for the option | ||
| * @return A SelectOption with the provided label and value | ||
| */ | ||
| public static SelectOption of(@NotNull String label, @NotNull String value) { |
| /** | ||
| * Components that can be inserted inside layout components (buttons & select menus) | ||
| */ | ||
| public interface ActionComponent extends Component { |
Owner
There was a problem hiding this comment.
Add withDisabled and isDisabled to this, with overrides on button and select menu to return their respective types.
| } | ||
|
|
||
| @JSONPropertyIgnore | ||
| public boolean isDef() { |
Owner
There was a problem hiding this comment.
This is undescriptive, I have no idea what this getter is.
| private final String value; | ||
| private final String description; | ||
| private PartialEmoji emoji; | ||
| private final boolean def; |
Owner
There was a problem hiding this comment.
Call this isDefault to avoid the keyword error
|
|
||
| @NotNull | ||
| @JSONPropertyIgnore | ||
| public String getLabel() { |
Owner
There was a problem hiding this comment.
All these getters need docs
Added missing annotations Added SingleEmojiContainer
Author
|
Fixed most if not all of the issues |
|
What happened to this? |
This was referenced Jul 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46
Components are only supported for application owned webhooks.
Other webhooks wont work with components due to discord limitations.
Please review the java docs once, I am bad at documenting