Skip to content

Fixed requests patch issue #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025
Merged

Fixed requests patch issue #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76e1cd2
Fixed requests patch issue
Minitour Apr 16, 2025
8b67e1d
Merge branch 'patch-1' into master
Minitour Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions aws_xray_sdk/ext/requests/patch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@


def patch():

wrapt.wrap_function_wrapper(
'requests',
'Session.send',
Expand All @@ -22,7 +21,7 @@ def patch():

def _xray_traced_requests(wrapped, instance, args, kwargs):

url = args[1].url
url = args[0].url

return xray_recorder.record_subsegment(
wrapped, instance, args, kwargs,
Expand All @@ -43,9 +42,10 @@ def _inject_header(wrapped, instance, args, kwargs):

def requests_processor(wrapped, instance, args, kwargs,
return_value, exception, subsegment, stack):

method = kwargs.get('method') or args[0]
url = kwargs.get('url') or args[1]

request = args[0]
method = request.method
url = request.url

subsegment.put_http_meta(http.METHOD, method)
subsegment.put_http_meta(http.URL, strip_url(url))
Expand Down