Fix Typo in Example 1 - Update Set-CIPolicySetting.md #4054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo in example 1. The reason is that supplying "$True" actually results in a typo in the XML file where "True" is capitalized -- this doesn't fit the XML specifications of code integrity policies, and actually leads to an error. (See PowerShell/PowerShell#21286 for a discussion on this). This change makes example 1 conform to other Microsoft documentation which uses a correct example of this cmdlet, see: https://learn.microsoft.com/en-us/windows/security/application-security/application-control/app-control-for-business/design/allow-com-object-registration-in-appcontrol-policy
Contributor
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
Contributor
|
Learn Build status updates of commit 958c96a: ✅ Validation status: passed
For more details, please refer to the build report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix typo in example 1.
The reason is that supplying "$True" actually results in a typo in the XML file where "True" is capitalized -- this doesn't fit the XML specifications of code integrity policies, and actually leads to an error. (See PowerShell/PowerShell#21286 for a discussion on this particular bug).
This change makes example 1 conform to other Microsoft documentation which uses a correct example of this cmdlet, see: https://learn.microsoft.com/en-us/windows/security/application-security/application-control/app-control-for-business/design/allow-com-object-registration-in-appcontrol-policy
PR Checklist