Skip to content

Conversation

Dickson-Mwendia
Copy link
Contributor

No description provided.

@Dickson-Mwendia Dickson-Mwendia requested a review from a team as a code owner July 30, 2025 10:31
Copy link
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. ms.custom was not added in alpha order for the metadata. But I also see other examples before this that are out of order, so it may not matter. Personally I only care about alpha order if we have really long metadata to read through, which we don't. Some folks do care.

@tdykstra, do you care if ms.custom is placed in alpha order? If not I am fine with this and approve.

@wadepickett
Copy link
Contributor

Thanks @Dickson-Mwendia! I'll get @tdykstra's opinion on alpha order this morning (see above), otherwise looks great and will approve.

Copy link
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since the other reviewer may not be available and with this many files involved we will collect merge conflicts quickly if it is not merged soon. Thanks @Dickson-Mwendia!

@wadepickett wadepickett merged commit b40e030 into MicrosoftDocs:main Aug 1, 2025
2 checks passed
@tdykstra
Copy link
Collaborator

tdykstra commented Aug 1, 2025

@wadepickett I agree with your assessment that we don't have enough metadata for the order to make a difference worth spending time to correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants