Skip to content

Conversation

@sehoff16
Copy link

Changed resource type from "Microsoft.Resources/resources" to "Microsoft.ResourceGraph/resourceChanges", thinking we have a typo here.

Changed resource type from "Microsoft.Resources/resources" to "Microsoft.ResourceGraph/resourceChanges", thinking we have a typo here.
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit a96f9ce:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-monitor/change/change-analysis-migration.md ✅Succeeded

For more details, please refer to the build report.

@v-dirichards
Copy link
Contributor

@hhunter-ms

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator
Copy link
Contributor

@sehoff16 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@prmerger-automator
Copy link
Contributor

@sehoff16 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@github-actions
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Aug 26, 2025
@v-dirichards
Copy link
Contributor

@hhunter-ms Could you review this proposed update to your article and enter #sign-off in a comment if it's ready to merge?

Thanks!

@github-actions github-actions bot removed the inactive This PR is inactive for more than 14 days label Aug 27, 2025
@github-actions
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Sep 10, 2025
@v-dirichards v-dirichards requested a review from Copilot October 2, 2025 21:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects a resource type reference in the Change Analysis migration documentation from an incorrect Microsoft.Resources/resources to the correct Microsoft.ResourceGraph/resourceChanges.

  • Fixes the resource type specification in a comparison table between Change Analysis classic and the new Resource Graph-powered API

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

| Web app in-app data (app settings, file changes, environmental variables) | Yes | No |
| Automatic onboarding for data collection | No | Yes |
| Resource type | `Microsoft.ChangeAnalysis/changes` and `Microsoft.ChangeAnalysis/ resourcechanges` | `Microsoft.Resources/ resources` |
| Resource type | `Microsoft.ChangeAnalysis/changes` and `Microsoft.ChangeAnalysis/ resourcechanges` | `Microsoft.ResourceGraph/ resourceChanges` |
Copy link

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent spacing in resource type names. There should be no space before the forward slash in Microsoft.ChangeAnalysis/ resourcechanges and Microsoft.ResourceGraph/ resourceChanges.

Suggested change
| Resource type | `Microsoft.ChangeAnalysis/changes` and `Microsoft.ChangeAnalysis/ resourcechanges` | `Microsoft.ResourceGraph/ resourceChanges` |
| Resource type | `Microsoft.ChangeAnalysis/changes` and `Microsoft.ChangeAnalysis/resourcechanges` | `Microsoft.ResourceGraph/resourceChanges` |

Copilot uses AI. Check for mistakes.
@v-dirichards
Copy link
Contributor

@hhunter-ms

Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

@github-actions github-actions bot removed the inactive This PR is inactive for more than 14 days label Oct 3, 2025
@github-actions
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aq-pr-triaged C+L Pull Request Review Team label azure-monitor/svc Change sent to author change-analysis/subsvc do-not-merge inactive This PR is inactive for more than 14 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants