-
Notifications
You must be signed in to change notification settings - Fork 21.8k
docs(acr): update AcrImageSigner role #127688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs(acr): update AcrImageSigner role #127688
Conversation
@lizMSFT : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
@yizha1 update the description for acrimagesigner role |
Learn Build status updates of commit 9d74eee: ✅ Validation status: passed
For more details, please refer to the build report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the documentation for the AcrImageSigner built-in role to reflect its planned deprecation. The change adds a deprecation notice indicating that the role will be removed on March 31, 2028, due to the deprecation of the ACR Content Trust feature.
Key changes:
- Updated AcrImageSigner role description to include deprecation notice and timeline
- Added reference link for migration guidance
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I rely on Rayo for editor comments.
The AcrImageSigner role is used for the ACR Content Trust feature. Since we plan to deprecate this feature, the role will also be deprecated in the future.
https://learn.microsoft.com/en-us/azure/container-registry/container-registry-content-trust-deprecation