build: upgrade asset controllers to @73.0.1

[Prithpal-Sooriya]

Description

This includes token balance fixes and performance improvements

Changelog

CHANGELOG entry: upgrade @metamask/[email protected]

Related issues

Fixes: #17412

Manual testing steps

N/A

Screenshots/Recordings

Before

After

https://www.loom.com/share/b21f66084b274adfb5526dc8afc7533e?sid=990c9257-9d9d-4c49-a9dc-7f9e96d9863f

Performance

Key improvement here is the reduction of RPC spam by using a multicall on the AccountTrackerController

Before

We were making many RPC calls for this, so much so that I got rate limited.

Number of RPC calls = # of accounts * # of chains
E.g. 100 Accounts * 6 chains = 600 RPC calls

https://www.loom.com/share/b201ebda42a74a879fa78402f3420ce8?sid=1640e528-6c68-4230-bef8-4f3722d67a01

After

Now we have a multicall group RPC call to drastically reduce the number of RPC calls made

Number of RPC calls = # of chains
E.g. 6 chains = 6 RPC calls

We have some further improvements to reduce duplicate RPC calls made by AccountTrackerController and TokenBalancesController in future PRs.

https://www.loom.com/share/801dfd74874f41c89a788f151c3430a7?sid=fdc62ff6-b122-4ec1-b9bc-fb7349de76e0

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5438891
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/19cd25ab-691e-45a0-bcaa-abab40e5d19a

Note

• You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/​@​types/​bn.js@​5.1.5 ⏵ 5.2.0	+1		+1
	npm/​undici-types@​7.8.0
	npm/​@​metamask/​phishing-controller@​13.1.0
	npm/​pony-cause@​2.1.10 ⏵ 2.1.11	+1
	npm/​@​types/​debug@​4.1.7 ⏵ 4.1.12			-2
	npm/​@​types/​ms@​0.7.31 ⏵ 2.1.0			+34
	npm/​@​types/​node@​22.7.5 ⏵ 24.1.0	+1		+1
	npm/​debug@​4.4.1
	npm/​bignumber.js@​9.3.0 ⏵ 9.3.1
	npm/​@​metamask/​assets-controllers@​72.0.0 ⏵ 73.0.1	+2		+1	+1

View full report

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7573ce6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a69876e5-245b-426a-be9c-370749562556

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sethkfman]

@Prithpal-Sooriya Can you add a perf tooling recording of the asset view with these changes before and after? It would be good to know the impact of this change.

[Prithpal-Sooriya]

@sethkfman I've attached a before and after vid. This improvement is solely focused on the network tab by drastically reducing the number of RPC calls we are making and processing.

We have further improvements coming down in future controller releases.

Now that devs have an easy view into the network tab, we can start being more critical to network requests.