Skip to content

fix: onboarding flash loading on oauth login #17732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2025

Conversation

ieow
Copy link
Contributor

@ieow ieow commented Jul 30, 2025

Description

During successfull oauth login, there is flash loading screen to onboarding screen before move to choosePassword screen

This PR fix the flash loading issue

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to onboarding screen
  2. Login with social
  3. Before navigate to next screen, loading should not stop

Screenshots/Recordings

Before

Screen.Recording.2025-07-31.at.4.38.51.PM.mov

After

Screen.Recording.2025-07-31.at.4.19.41.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-web3auth Web3Auth team label Jul 30, 2025
@ieow ieow self-assigned this Jul 30, 2025
@ieow ieow marked this pull request as ready for review July 30, 2025 14:59
@ieow ieow requested a review from a team as a code owner July 30, 2025 14:59
@ieow ieow added the Run Smoke E2E Requires smoke E2E testing label Jul 30, 2025
Copy link
Contributor

github-actions bot commented Jul 30, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 09d59b6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/882f5ac5-1e05-479b-b29f-a91dd267a93a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]

This comment was marked as outdated.

Copy link

@chaitanyapotti chaitanyapotti added the No QA Needed Apply this label when your PR does not need any QA effort. label Jul 31, 2025
@chaitanyapotti chaitanyapotti added this pull request to the merge queue Jul 31, 2025
Merged via the queue into main with commit d95f4a3 Jul 31, 2025
118 of 122 checks passed
@chaitanyapotti chaitanyapotti deleted the fix/onboarding-flash-loading branch July 31, 2025 11:29
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-onboarding No QA Needed Apply this label when your PR does not need any QA effort. release-7.53.0 Issue or pull request that will be included in release 7.53.0 Run Smoke E2E Requires smoke E2E testing team-web3auth Web3Auth team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants