Readable delegation manager #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could have gas performance improved by re-implementing the |
|
Missing an "a" in "manager"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a new
SafeDelegationMangerwhich receives its caveats in a human-readable form, and decodes them into the usual form for enforcement.Why?
When considering how readable these delegations could be on a 3rd party hardware wallet that only supports ERC-712, we realized the caveat enforcers were falling short of where we'd ideally have their readability.
It seemed like a maximally security conscious user of a hardware wallet might prefer a contract account that ensured they had improved readability on the hardware wallet in exchange for gas cost.
How?
Subclasses the usual DelegationManager, and first transforms its received
ReadableDelegationobjects into traditionalDelegations.Is only compatible with caveat enforcers that:
_convertReadableTermsToCaveatsmethod.SafeDelegationManager'stermsToEnforcermap, creating a limited, permissioned set of caveats.As a bonus, I made it throw an error if it receives an empty caveats array, to minimize another footgun that is lying around.