Skip to content

Conversation

Julink-eth
Copy link
Contributor

Explanation

Add a list of networks that will be treated as whitelisted not to display the warning messages in the clients (Extension/Mobile) when adding them as custom networks.
This list is starting with HyperEVM network.

References

Related to MetaMask/metamask-mobile#19167
Related to MetaMask/metamask-extension#35609

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Julink-eth Julink-eth requested a review from a team as a code owner September 11, 2025 07:12
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made some suggestions as it relates directly to these changes. However, have we considered porting over the chain collision check from the clients itself rather than just the mapping? If the goal is to consolidate the behavior around network validation then it seems like that would satisfy the goal in a more maintainable way. As it is, if we just bring over the mapping, we are allowing the behavior to deviate (because developers could use this constant in a way that wasn't intended, or worse, not use it at all).

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Julink-eth Julink-eth merged commit a84994b into main Sep 15, 2025
239 checks passed
@Julink-eth Julink-eth deleted the chore/utils-whitelist-networks branch September 15, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants