-
-
Notifications
You must be signed in to change notification settings - Fork 246
chore: add whitelist to utils to ignore warnings for specific networks #6557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made some suggestions as it relates directly to these changes. However, have we considered porting over the chain collision check from the clients itself rather than just the mapping? If the goal is to consolidate the behavior around network validation then it seems like that would satisfy the goal in a more maintainable way. As it is, if we just bring over the mapping, we are allowing the behavior to deviate (because developers could use this constant in a way that wasn't intended, or worse, not use it at all).
Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Explanation
Add a list of networks that will be treated as whitelisted not to display the warning messages in the clients (Extension/Mobile) when adding them as custom networks.
This list is starting with HyperEVM network.
References
Related to MetaMask/metamask-mobile#19167
Related to MetaMask/metamask-extension#35609
Checklist