Skip to content

feat(accounts-controller): add new typed options for InternalAccounts #6147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 22, 2025
Merged

feat(accounts-controller): add new typed options for InternalAccounts #6147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
254e0a5
feat(accounts-controller): add new typed options for InternalAccount(s)
ccharly Jul 18, 2025
1544411
test: re-use controller-utils + add it as a dev dep
ccharly Jul 18, 2025
81ef5d1
refactor: use same logic for updateAccounts
ccharly Jul 18, 2025
8f20a0a
chore: cosmetic
ccharly Jul 18, 2025
c476e64
chore: rename getGroupIndexFromAddress -> getGroupIndexFromAddressIndex
ccharly Jul 18, 2025
752321a
refactor: re-add isNormalKeyringType + tests
ccharly Jul 18, 2025
2777129
test: better tests
ccharly Jul 18, 2025
ab85154
chore: lint
ccharly Jul 18, 2025
928b0ef
chore: update changelog
ccharly Jul 18, 2025
55702c0
fix: remove unused @ts-expect-error
ccharly Jul 18, 2025
97b5829
chore: lint
ccharly Jul 21, 2025
41744b3
refactor: rename getDerivationPathForIndex + getGroupIndexFromAddress…
ccharly Jul 22, 2025
1780e9d
chore: update jsdoc
ccharly Jul 22, 2025
ff88f99
chore: add TODO
ccharly Jul 22, 2025
31e2b13
fix: use toLowerCase when comparing EVM addresses
ccharly Jul 22, 2025
1d5c2cf
fix: force deep copy of Snap accounts
ccharly Jul 22, 2025
7a70975
chore: lint
ccharly Jul 22, 2025
7423035
refactor: refactor automatic naming logic
ccharly Jul 22, 2025
f5cae67
Merge branch 'main' into feat/use-keyring-typed-options
ccharly Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/accounts-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

- Add `groupIndex` to EVM HD account options ([#6122](https://github.com/MetaMask/core/pull/6122))
- Use new typed `KeyringAccount.options` for BIP-44 compatible accounts ([#6122](https://github.com/MetaMask/core/pull/6122)), ([#6147](https://github.com/MetaMask/core/pull/6147))

### Changed

Expand Down
3 changes: 3 additions & 0 deletions packages/accounts-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,17 @@
"@metamask/keyring-utils": "^3.1.0",
"@metamask/snaps-sdk": "^9.0.0",
"@metamask/snaps-utils": "^11.0.0",
"@metamask/superstruct": "^3.1.0",
"@metamask/utils": "^11.4.2",
"deepmerge": "^4.2.2",
"ethereum-cryptography": "^2.1.2",
"immer": "^9.0.6",
"lodash": "^4.17.21",
"uuid": "^8.3.2"
},
"devDependencies": {
"@metamask/auto-changelog": "^3.4.4",
"@metamask/controller-utils": "^11.11.0",
"@metamask/keyring-controller": "^22.1.0",
"@metamask/network-controller": "^24.0.1",
"@metamask/providers": "^22.1.0",
Expand Down
Loading
Loading