feat: Add Messenger parent parameter
#6142
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods `delegate` and `revoke` have been added to the Messenger class. These methods replace the need for the `RestrictedMessenger`. The `getRestricted` method, and the `RestrictedMessenger` class, have been removed as obsolete. See this ADR PR for details: MetaMask/decisions#53
Gudahtt
force-pushed
the
add-messenger-parent-param
branch
from
73f9dd4 to
c07ba89
Compare
Gudahtt
force-pushed
the
add-messenger-parent-param
branch
from
c07ba89 to
4ff719e
Compare
Add the `parent` constructor parameter to the `Messenger` class for automatic delegation of all capabilities under that messenger's namespace. This significantly reduces boilerplate, making the messenger easier to use in a similar manner to how the old `RestrictedMessenger` class wored. See this ADR PR for details: MetaMask/decisions#53
Gudahtt
force-pushed
the
add-messenger-parent-param
branch
from
4ff719e to
f3e18ba
Compare
Gudahtt
changed the title
parant parameterparent parameter
Gudahtt
force-pushed
the
add-messenger-delegation
branch
from
2dd241a to
6729773
Compare
mcmire
reviewed
Jul 23, 2025
Comment on lines
+141
to
+145
| readonly #parent?: Messenger< | ||
| string, | ||
| Action | ActionConstraint, | ||
| Event | EventConstraint | ||
| >; |
There was a problem hiding this comment.
Is it true that 1) all of the actions and events in this messenger are eligible for delegation, and because of this, 2) all of the actions and events that the parent knows about must be known to this messenger too? If so, can we say this?
Suggested change
| readonly #parent?: Messenger< | |
| string, | |
| Action | ActionConstraint, | |
| Event | EventConstraint | |
| >; | |
| readonly #parent?: DelegatedMessenger<Action, Event>; |
Comment on lines
+203
to
+207
| parent?: Messenger< | ||
| string, | ||
| Action | ActionConstraint, | ||
| Event | EventConstraint | ||
| >; |
There was a problem hiding this comment.
Similar as above, can we say this?
Suggested change
| parent?: Messenger< | |
| string, | |
| Action | ActionConstraint, | |
| Event | EventConstraint | |
| >; | |
| parent?: DelegatedMessenger<Action, Event>; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Add the
parentconstructor parameter to theMessengerclass for automatic delegation of all capabilities under that messenger's namespace. This significantly reduces boilerplate, making the messenger easier to use in a similar manner to how the oldRestrictedMessengerclass wored.See this ADR PR for details: MetaMask/decisions#53
References
Depends upon #6132
Relates to #5626
Checklist