Skip to content

Create shield controller #6137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Conversation

matthiasgeihs
Copy link
Contributor

Explanation

New controller for MetaMask Shield.

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@chaitanyapotti chaitanyapotti added the area-shield Transaction Shield label Jul 18, 2025
/**
* The internal actions available to the ShieldController.
*/
export type ShieldControllerActions = ShieldControllerCheckCoverageAction;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we put all the types in separate file, e.g. types.ts

@@ -20,8 +20,6 @@ export default async function cli(
// Disable --version. This is an internal tool and it doesn't have a version.
.version(false)
.usage('$0 [args]')
// @ts-expect-error: The CommandModule<T, U>[] signature does in fact exist,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I know why do we need to update this?
If it's not working, I think we should do it in separate PR :)

Copy link

socket-security bot commented Jul 25, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​metamask/​transaction-controller@​58.1.1961007999100
Added@​metamask/​profile-sync-controller@​21.0.09610086100100

View full report

Copy link

socket-security bot commented Jul 25, 2025

Caution

Review the following alerts detected in dependencies.

According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Block Low
[email protected] has a New author.

New Author: dignifiedquire

Previous Author: devongovett

From: ?npm/@metamask/[email protected]npm/@metamask/[email protected]npm/[email protected]

ℹ Read more on: This package | This alert | What is new author?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@matthiasgeihs matthiasgeihs force-pushed the mg/create-shield-controller branch from 8e91db5 to a6d65ff Compare July 28, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants