-
-
Notifications
You must be signed in to change notification settings - Fork 241
Create shield controller #6137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Create shield controller #6137
Conversation
/** | ||
* The internal actions available to the ShieldController. | ||
*/ | ||
export type ShieldControllerActions = ShieldControllerCheckCoverageAction; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice if we put all the types in separate file, e.g. types.ts
@@ -20,8 +20,6 @@ export default async function cli( | |||
// Disable --version. This is an internal tool and it doesn't have a version. | |||
.version(false) | |||
.usage('$0 [args]') | |||
// @ts-expect-error: The CommandModule<T, U>[] signature does in fact exist, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I know why do we need to update this?
If it's not working, I think we should do it in separate PR :)
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Caution Review the following alerts detected in dependencies. According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. Learn more about Socket for GitHub.
|
8e91db5
to
a6d65ff
Compare
Explanation
New controller for MetaMask Shield.
References
Changelog
Checklist